ath79: gpio-latch-mikrotik: use devm_mutex_init

Avoids needing to call mutex_destroy in error paths, which is missing
anyway.

Signed-off-by: Rosen Penev <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/16620
Signed-off-by: Robert Marko <[email protected]>

diff --git a/target/linux/ath79/files/drivers/gpio/gpio-latch-mikrotik.c b/target/linux/ath79/files/drivers/gpio/gpio-latch-mikrotik.c
index 70f091b79ff398e438070779eb8848631f1e1236..6e3f0f9690e75c00393a20a27653e2c9e85259c5 100644 (file)
--- a/target/linux/ath79/files/drivers/gpio/gpio-latch-mikrotik.c
+++ b/target/linux/ath79/files/drivers/gpio/gpio-latch-mikrotik.c
@@ -110,14 +110,19 @@ static int gpio_latch_probe(struct platform_device *pdev)
        struct gpio_latch_chip *glc;
        struct gpio_chip *gc;
        struct device *dev = &pdev->dev;
-       int i, n;
+       int err, i, n;
 
        glc = devm_kzalloc(dev, sizeof(*glc), GFP_KERNEL);
        if (!glc)
                return -ENOMEM;
 
-       mutex_init(&glc->mutex);
-       mutex_init(&glc->latch_mutex);
+       err = devm_mutex_init(&pdev->dev, &glc->mutex);
+       if (err)
+               return err;
+
+       err = devm_mutex_init(&pdev->dev, &glc->latch_mutex);
+       if (err)
+               return err;
 
        n = gpiod_count(dev, NULL);
        if (n <= 0)