NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check
if the neighbour pointer is valid before dereferencing it.

Signed-off-by: Ralf Baechle <[email protected]>
Tested-by: Bernard Pidoux <[email protected]>
Cc: [email protected] #2.6.11+
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c
index 8ae603069a1a1706982dc0b7affd5443cb912308..dd304bc40788d5001820530842db936201965fb6 100644 (file)
--- a/net/rose/af_rose.c
+++ b/net/rose/af_rose.c
@@ -192,7 +192,8 @@ static void rose_kill_by_device(struct net_device *dev)
 
                if (rose->device == dev) {
                        rose_disconnect(s, ENETUNREACH, ROSE_OUT_OF_ORDER, 0);
-                       rose->neighbour->use--;
+                       if (rose->neighbour)
+                               rose->neighbour->use--;
                        rose->device = NULL;
                }
        }