projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3bd1f7e
)
Input: cyttsp - fix memcpy size param
author
Ferruh Yigit
<
[email protected]
>
Thu, 23 May 2013 16:56:55 +0000
(09:56 -0700)
committer
Dmitry Torokhov
<
[email protected]
>
Thu, 6 Jun 2013 05:46:30 +0000
(22:46 -0700)
memcpy param is wrong because of offset in bl_cmd, this may corrupt the
stack which may cause a crash.
Tested-by: Ferruh Yigit <
[email protected]
> on TMA300-DVK
Signed-off-by: Ferruh Yigit <
[email protected]
>
Acked-by: Javier Martinez Canillas <
[email protected]
>
Cc:
[email protected]
Signed-off-by: Dmitry Torokhov <
[email protected]
>
drivers/input/touchscreen/cyttsp_core.c
patch
|
blob
|
history
diff --git
a/drivers/input/touchscreen/cyttsp_core.c
b/drivers/input/touchscreen/cyttsp_core.c
index 8e60437ac85b46569e57ae78f2bea455fd1b9ab5..97ba8912831256ec38a52be591ae30b38d20e8ab 100644
(file)
--- a/
drivers/input/touchscreen/cyttsp_core.c
+++ b/
drivers/input/touchscreen/cyttsp_core.c
@@
-133,7
+133,7
@@
static int cyttsp_exit_bl_mode(struct cyttsp *ts)
memcpy(bl_cmd, bl_command, sizeof(bl_command));
if (ts->pdata->bl_keys)
memcpy(&bl_cmd[sizeof(bl_command) - CY_NUM_BL_KEYS],
- ts->pdata->bl_keys,
sizeof(bl_command)
);
+ ts->pdata->bl_keys,
CY_NUM_BL_KEYS
);
error = ttsp_write_block_data(ts, CY_REG_BASE,
sizeof(bl_cmd), bl_cmd);