dmaengine: at_hdmac: use tasklet_kill in teardown

As discussed in [1] the tasklet_disable is not a proper function for teardown.
We need to ensure irq is disabled, followed by ensuring that don't schedule any
more tasklets and then its safe to use tasklet_kill().

Here in at_hdmac driver we use free_irq() before tasklet_kill(). The free_irq()
will ensure that the irq is disabled and also wait till all scheduled interrupts
are executed by invoking synchronize_irq(). So we need to only do tasklet_kill()
after invoking free_irq()

[1]: http://lwn.net/Articles/588457/

Reported-by: Thomas Gleixner <[email protected]>
Acked-by: Nicolas Ferre <[email protected]>
Reviewed-by: Thomas Gleixner <[email protected]>
Signed-off-by: Vinod Koul <[email protected]>

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index e2c04dc81e2a903ea13956e872150c40ed8b00e8..c13a3bb0f5943234fac845d3214309a3c754c63a 100644 (file)
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -1569,7 +1569,6 @@ static int at_dma_remove(struct platform_device *pdev)
 
                /* Disable interrupts */
                atc_disable_chan_irq(atdma, chan->chan_id);
-               tasklet_disable(&atchan->tasklet);
 
                tasklet_kill(&atchan->tasklet);
                list_del(&chan->device_node);