NET: bna, fix lock imbalance

bnad_set_rx_mode omit to unlock bna_lock on one fail path. Fix that.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Debashis Dutt <[email protected]>
Cc: Rasesh Mody <[email protected]>
Cc: David S. Miller <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/bna/bnad.c b/drivers/net/bna/bnad.c
index 44adc7aefddc13e2325e7f3a2fbb1cba367a0de9..8158fb93cb4c595351d007a7f2196b2659a40985 100644 (file)
--- a/drivers/net/bna/bnad.c
+++ b/drivers/net/bna/bnad.c
@@ -2702,7 +2702,7 @@ bnad_set_rx_mode(struct net_device *netdev)
                        kzalloc((mc_count + 1) * ETH_ALEN,
                                GFP_ATOMIC);
                if (!mcaddr_list)
-                       return;
+                       goto unlock;
 
                memcpy(&mcaddr_list[0], &bnad_bcast_addr[0], ETH_ALEN);
 
@@ -2715,6 +2715,7 @@ bnad_set_rx_mode(struct net_device *netdev)
                /* Should we enable BNAD_CF_ALLMULTI for err != 0 ? */
                kfree(mcaddr_list);
        }
+unlock:
        spin_unlock_irqrestore(&bnad->bna_lock, flags);
 }