Revert "drm: Don't allow interruptions when opening debugfs/crc"

This reverts

commit b8dfa821c27046ede9bf8eb14cc8109d379428e9
Author: Chris Wilson <[email protected]>
Date:   Fri Apr 7 12:17:12 2017 +0100
    drm: Don't allow interruptions when opening debugfs/crc

It reportedly breaks things, so let's revert now and try again later.

Fixes: b8dfa821c270 ("drm: Don't allow interruptions when opening debugfs/crc")
Cc: Chris Wilson <[email protected]>
Cc: Tomeu Vizoso <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Jani Nikula <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Reported-by: Chris Wilson <[email protected]>
Acked-by: Chris Wilson <[email protected]>
Acked-by: Daniel Vetter <[email protected]>
Signed-off-by: Sean Paul <[email protected]>

diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c
index aa13e734c9e570ca4a28aa2862ee49202d7ef05b..1722d8f214499794d5304dc7e9597bfcd0dadd6b 100644 (file)
--- a/drivers/gpu/drm/drm_debugfs_crc.c
+++ b/drivers/gpu/drm/drm_debugfs_crc.c
@@ -177,9 +177,13 @@ static int crtc_crc_open(struct inode *inode, struct file *filep)
         * guess when this particular piece of HW will be ready to start
         * generating CRCs.
         */
-       wait_event_lock_irq(crc->wq, crtc_crc_data_count(crc), crc->lock);
+       ret = wait_event_interruptible_lock_irq(crc->wq,
+                                               crtc_crc_data_count(crc),
+                                               crc->lock);
        spin_unlock_irq(&crc->lock);
 
+       WARN_ON(ret);
+
        return 0;
 
 err_disable: