ar71xx: image: keep custom Build/* functions in separate files

Most of the custom Build/* functions in ar71xx target are rarely used by
image building code for devices from more than one subtarget. As they
don't need to be always included, move them to corresponding *.mk files.

Signed-off-by: Piotr Dymacz <[email protected]>

diff --git a/target/linux/ar71xx/image/Makefile b/target/linux/ar71xx/image/Makefile
index 32951e53477a79f6369f3b9e68044221934835b1..72ae3d59ff779070d8ff31ab2cf515161cdcac16 100644 (file)
--- a/target/linux/ar71xx/image/Makefile
+++ b/target/linux/ar71xx/image/Makefile
@@ -10,7 +10,7 @@ include $(INCLUDE_DIR)/image.mk
 
 KERNEL_LOADADDR = 0x80060000
 
-DEVICE_VARS += NETGEAR_KERNEL_MAGIC NETGEAR_BOARD_ID NETGEAR_HW_ID CMDLINE CONSOLE IMAGE_SIZE BOARDNAME LOADER_FLASH_OFFS LOADER_TYPE
+DEVICE_VARS += BOARDNAME CMDLINE CONSOLE IMAGE_SIZE LOADER_TYPE
 
 ifeq ($(SUBTARGET),generic)
 include ./tp-link.mk
@@ -27,29 +27,6 @@ include ./mikrotik.mk
 endif
 include ./legacy.mk
 
-define Build/netgear-squashfs
-       rm -rf [email protected] [email protected]
-       mkdir -p [email protected]/image
-       cp $@ [email protected]/image/uImage
-       $(STAGING_DIR_HOST)/bin/mksquashfs-lzma \
-               [email protected] [email protected] \
-               -noappend -root-owned -be -b 65536 \
-               $(if $(SOURCE_DATE_EPOCH),-fixed-time $(SOURCE_DATE_EPOCH))
-
-       dd if=/dev/zero bs=1k count=1 >> [email protected]
-       mkimage \
-               -A mips -O linux -T filesystem -C none \
-               -M $(NETGEAR_KERNEL_MAGIC) \
-               -a 0xbf070000 -e 0xbf070000 \
-               -n 'MIPS OpenWrt Linux-$(LINUX_VERSION)' \
-               -d [email protected] $@
-       rm -rf [email protected] [email protected]
-endef
-
-define Build/netgear-uImage
-       $(call Build/uImage,$(1) -M $(NETGEAR_KERNEL_MAGIC))
-endef
-
 define Build/loader-common
        rm -rf [email protected]
        $(MAKE) -C lzma-loader \
@@ -62,10 +39,6 @@ define Build/loader-common
        rm -rf [email protected]
 endef
 
-define Build/loader-okli-compile
-       $(call Build/loader-common,FLASH_OFFS=$(LOADER_FLASH_OFFS) FLASH_MAX=0 KERNEL_CMDLINE="$(CMDLINE)")
-endef
-
 define Build/loader-kernel
        $(call Build/loader-common,LOADER_DATA="$@")
 endef
@@ -74,29 +47,6 @@ define Build/loader-kernel-cmdline
        $(call Build/loader-common,LOADER_DATA="$@" KERNEL_CMDLINE="$(CMDLINE)")
 endef
 
-define Build/loader-okli
-       dd if=$(KDIR)/loader-$(1).gz bs=7680 conv=sync of="[email protected]"
-       cat "$@" >> "[email protected]"
-       mv "[email protected]" "$@"
-endef
-
-define Build/relocate-kernel
-       rm -rf [email protected]
-       $(CP) ../../generic/image/relocate [email protected]
-       $(MAKE) -j1 -C [email protected] KERNEL_ADDR=$(KERNEL_LOADADDR) CROSS_COMPILE=$(TARGET_CROSS)
-       ( \
-               dd [email protected]/loader.bin bs=32 conv=sync && \
-               perl -e '@s = stat("$@"); print pack("N", @s[7])' && \
-               cat "$@" \
-       ) > "[email protected]"
-       mv "[email protected]" "$@"
-       rm -rf [email protected]
-endef
-
-define Build/copy-file
-       cat "$(1)" > "$@"
-endef
-
 define Device/Default
   BOARDNAME :=
   DEVICE_PROFILE = $$(BOARDNAME)

diff --git a/target/linux/ar71xx/image/generic.mk b/target/linux/ar71xx/image/generic.mk
index 949fadb07cf9bdaf1608ca3e9a2d1b4e558c823a..158d5662fe40e2de34a49ec89cd5f3b3f524db27 100644 (file)
--- a/target/linux/ar71xx/image/generic.mk
+++ b/target/linux/ar71xx/image/generic.mk
@@ -1,4 +1,4 @@
-DEVICE_VARS += DAP_SIGNATURE SEAMA_SIGNATURE
+DEVICE_VARS += DAP_SIGNATURE NETGEAR_BOARD_ID NETGEAR_HW_ID NETGEAR_KERNEL_MAGIC SEAMA_SIGNATURE
 
 define Build/mkbuffaloimg
        $(STAGING_DIR_HOST)/bin/mkbuffaloimg -B $(BOARDNAME) \
@@ -16,6 +16,42 @@ define Build/mkwrggimg
        mv [email protected] $@
 endef
 
+define Build/netgear-squashfs
+       rm -rf [email protected] [email protected]
+       mkdir -p [email protected]/image
+       cp $@ [email protected]/image/uImage
+       $(STAGING_DIR_HOST)/bin/mksquashfs-lzma \
+               [email protected] [email protected] \
+               -noappend -root-owned -be -b 65536 \
+               $(if $(SOURCE_DATE_EPOCH),-fixed-time $(SOURCE_DATE_EPOCH))
+
+       dd if=/dev/zero bs=1k count=1 >> [email protected]
+       mkimage \
+               -A mips -O linux -T filesystem -C none \
+               -M $(NETGEAR_KERNEL_MAGIC) \
+               -a 0xbf070000 -e 0xbf070000 \
+               -n 'MIPS OpenWrt Linux-$(LINUX_VERSION)' \
+               -d [email protected] $@
+       rm -rf [email protected] [email protected]
+endef
+
+define Build/netgear-uImage
+       $(call Build/uImage,$(1) -M $(NETGEAR_KERNEL_MAGIC))
+endef
+
+define Build/relocate-kernel
+       rm -rf [email protected]
+       $(CP) ../../generic/image/relocate [email protected]
+       $(MAKE) -j1 -C [email protected] KERNEL_ADDR=$(KERNEL_LOADADDR) CROSS_COMPILE=$(TARGET_CROSS)
+       ( \
+               dd [email protected]/loader.bin bs=32 conv=sync && \
+               perl -e '@s = stat("$@"); print pack("N", @s[7])' && \
+               cat "$@" \
+       ) > "[email protected]"
+       mv "[email protected]" "$@"
+       rm -rf [email protected]
+endef
+
 define Build/seama
        $(STAGING_DIR_HOST)/bin/seama -i $@ $(if $(1),$(1),-m "dev=/dev/mtdblock/1" -m "type=firmware")
        mv [email protected] $@

diff --git a/target/linux/ar71xx/image/tp-link.mk b/target/linux/ar71xx/image/tp-link.mk
index 2d64846cc86189a2510e0656b2965f262203ec6b..26ac6dad0b19c6012100c07af892e6d3d6045073 100644 (file)
--- a/target/linux/ar71xx/image/tp-link.mk
+++ b/target/linux/ar71xx/image/tp-link.mk
@@ -1,4 +1,18 @@
-DEVICE_VARS += TPLINK_HWID TPLINK_HWREV TPLINK_FLASHLAYOUT TPLINK_HEADER_VERSION TPLINK_BOARD_NAME
+DEVICE_VARS += LOADER_FLASH_OFFS TPLINK_BOARD_NAME TPLINK_FLASHLAYOUT TPLINK_HEADER_VERSION TPLINK_HWID TPLINK_HWREV
+
+define Build/copy-file
+       cat "$(1)" > "$@"
+endef
+
+define Build/loader-okli
+       dd if=$(KDIR)/loader-$(1).gz bs=7680 conv=sync of="[email protected]"
+       cat "$@" >> "[email protected]"
+       mv "[email protected]" "$@"
+endef
+
+define Build/loader-okli-compile
+       $(call Build/loader-common,FLASH_OFFS=$(LOADER_FLASH_OFFS) FLASH_MAX=0 KERNEL_CMDLINE="$(CMDLINE)")
+endef
 
 # combine kernel and rootfs into one image
 # mktplinkfw <type> <optional extra arguments to mktplinkfw binary>