drm/amd/display: change when to set tap_hardcode_coeff

Set hardcode_coeff only when BOTH chroma and luma taps are
more than 1

without this underscan with h or v set to 0 darkens
the screen (either h or v set to 0, not both)

Signed-off-by: Bhawanpreet Lakha <[email protected]>
Reviewed-by: Tony Cheng <[email protected]>
Acked-by: Harry Wentland <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>

diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c
index 830dbd5d41444104fe207248192aed156a163080..eda6c8010fb8a5aaae3850774d55787e140ca43f 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp_dscl.c
@@ -306,10 +306,10 @@ static void dpp_set_scl_filter(
 
        h_2tap_hardcode_coef_en = scl_data->taps.h_taps < 3
                                        && scl_data->taps.h_taps_c < 3
-               && (scl_data->taps.h_taps > 1 || scl_data->taps.h_taps_c > 1);
+               && (scl_data->taps.h_taps > 1 && scl_data->taps.h_taps_c > 1);
        v_2tap_hardcode_coef_en = scl_data->taps.v_taps < 3
                                        && scl_data->taps.v_taps_c < 3
-               && (scl_data->taps.v_taps > 1 || scl_data->taps.v_taps_c > 1);
+               && (scl_data->taps.v_taps > 1 && scl_data->taps.v_taps_c > 1);
 
        h_2tap_sharp_en = h_2tap_hardcode_coef_en && h_2tap_sharp_factor != 0;
        v_2tap_sharp_en = v_2tap_hardcode_coef_en && v_2tap_sharp_factor != 0;