ibmveth: Return -EINVAL on all ->probe errors

We had a few cases where we returned success on error.

Signed-off-by: Anton Blanchard <[email protected]>
Signed-off-by: Santiago Leon <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
index 8adfff55792d13ce7ad73aaa7c5f4518a7cb89bb..11086dbe76e8b0488254280eb62d6eb4c9c9daf7 100644 (file)
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -1392,7 +1392,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
                                                        NULL);
        if (!mac_addr_p) {
                dev_err(&dev->dev, "Can't find VETH_MAC_ADDR attribute\n");
-               return 0;
+               return -EINVAL;
        }
 
        mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
@@ -1400,7 +1400,7 @@ static int __devinit ibmveth_probe(struct vio_dev *dev,
        if (!mcastFilterSize_p) {
                dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "
                        "attribute\n");
-               return 0;
+               return -EINVAL;
        }
 
        netdev = alloc_etherdev(sizeof(struct ibmveth_adapter));