tools: zynqimage: Clean up check_params

Clean up the param checking, removing some code paths that will never
happen.

Signed-off-by: Nathan Rossi <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: Tom Rini <[email protected]>
Reported-by: Coverity (CID 133251)
Reviewed-by: Tom Rini <[email protected]>
Signed-off-by: Michal Simek <[email protected]>

diff --git a/tools/zynqimage.c b/tools/zynqimage.c
index 25f558d24c789c0dbf119db88dff156ab4fdbb85..c43bd5d48820a1ba9337cc93b85fff08f21d461a 100644 (file)
--- a/tools/zynqimage.c
+++ b/tools/zynqimage.c
@@ -212,8 +212,7 @@ static int zynqimage_check_params(struct image_tool_params *params)
                return -1;
        }
 
-       return !((params->lflag || params->dflag) ||
-                       (params->dflag && params->eflag));
+       return !(params->lflag || params->dflag);
 }
 
 static int zynqimage_check_image_types(uint8_t type)