ddns-scripts: Fixup huaweicloud
authorLehua Zhang <[email protected]>
Wed, 26 Feb 2025 09:16:58 +0000 (17:16 +0800)
committerFlorian Eckert <[email protected]>
Tue, 4 Mar 2025 09:32:34 +0000 (10:32 +0100)
Script will exit when an error occurred.

Modify write_log 14 to write_log 4,
write_log 14 and write_log 4 can also print the same message,
but write_log 14 will exist script when printed.

Signed-off-by: Lehua Zhang <[email protected]>
net/ddns-scripts/Makefile
net/ddns-scripts/files/usr/lib/ddns/update_huaweicloud_com.sh

index aa31b1fe9eef45bce160801b17f6ea981b005e06..2db9b944830c3434b44834f5811faa4048eafa74 100644 (file)
@@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=ddns-scripts
 PKG_VERSION:=2.8.2
-PKG_RELEASE:=64
+PKG_RELEASE:=65
 
 PKG_LICENSE:=GPL-2.0
 
index 1c21b1d2e75562b9428433512a959a4e131c88fd..1ce866cd4d8919ea3d2354c2169cee00af33d3ed 100644 (file)
@@ -85,7 +85,7 @@ hcloud_transfer() {
                "https://$reqUrl"
 
        if [ $? -ne 0 ]; then
-               write_log 14 "rest api error"
+               write_log 4 "rest api error"
        fi
 }
 
@@ -93,8 +93,10 @@ get_zone() {
        local resp=`hcloud_transfer GET /v2/zones "name=$__DOMAIN.&search_mode=equal" ""`
        __ZONE_ID=`printf "%s" $resp |  grep -Eo '"id":"[a-z0-9]+"' | cut -d':' -f2 | tr -d '"'`
        if [ "$__ZONE_ID" = "" ]; then
-               write_log 14 "error, no zone"
+               write_log 4 "query zone error [$resp]"
+               return 1
        fi
+       return 0
 }
 
 upd_record() {
@@ -104,8 +106,10 @@ upd_record() {
        if [ ! "$recordId" = "" ]; then
                write_log 7 "upd [$recordId] success [$__TYPE] [$__IP]"
        else
-               write_log 14 "upd ecord error [$resp]"
+               write_log 4 "upd ecord error [$resp]"
+               return 1
        fi
+       return 0
 }
 
 add_record() {
@@ -115,8 +119,10 @@ add_record() {
        if [ ! "$recordId" = "" ]; then
                write_log 7 "add [$recordId] success [$__TYPE] [$__IP]"
        else
-               write_log 14 "add record error [$resp]"
+               write_log 4 "add record error [$resp]"
+               return 1
        fi
+       return 0
 }
 
 # Get DNS record
@@ -137,16 +143,18 @@ get_record() {
        return $ret
 }
 
-get_zone
+get_zone || return 1
 get_record
 
 ret=$?
 if [ $ret -eq 0 ]; then
        write_log 7 "nochg [$__IP]"
 fi
+
 if [ $ret -eq 1 ]; then
        add_record
 fi
+
 if [ $ret -eq 2 ]; then
        upd_record
 fi