NFS: Ensure we return zero if applications attempt to write zero bytes
authorChuck Lever <[email protected]>
Mon, 12 Nov 2007 17:16:58 +0000 (12:16 -0500)
committerTrond Myklebust <[email protected]>
Mon, 26 Nov 2007 21:32:38 +0000 (16:32 -0500)
A zero byte count direct write request should be a successful no-op, not an
error.

Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
fs/nfs/direct.c

index 88d5d1c7f987982e2c7324fe24052cd5b2ee6f26..4d726e9db2953a2315825040b724e3c5c27c0636 100644 (file)
@@ -890,6 +890,8 @@ ssize_t nfs_file_direct_write(struct kiocb *iocb, const struct iovec *iov,
        retval = generic_write_checks(file, &pos, &count, 0);
        if (retval)
                goto out;
+       if (!count)
+               goto out;       /* return 0 */
 
        retval = -EINVAL;
        if ((ssize_t) count < 0)