net: phy: mscc: remove unneeded parenthesis
authorQuentin Schulz <[email protected]>
Mon, 8 Oct 2018 10:07:26 +0000 (12:07 +0200)
committerDavid S. Miller <[email protected]>
Mon, 8 Oct 2018 17:29:21 +0000 (10:29 -0700)
The == operator precedes the || operator, so we can remove the
parenthesis around (a == b) || (c == d).

The condition is rather explicit and short so removing the parenthesis
definitely does not make it harder to read.

Reviewed-by: Florian Fainelli <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Quentin Schulz <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/net/phy/mscc.c

index d304fb4df23ca2ad454760c5246f25bc526fc3dc..0ff7803ed16bf7649b47b90913e12431f35cc796 100644 (file)
@@ -300,7 +300,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix)
        u16 reg_val;
 
        reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL);
-       if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) {
+       if (mdix == ETH_TP_MDI || mdix == ETH_TP_MDI_X) {
                reg_val |= (DISABLE_PAIR_SWAP_CORR_MASK |
                            DISABLE_POLARITY_CORR_MASK  |
                            DISABLE_HP_AUTO_MDIX_MASK);