projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e8379ec
)
[media] mn88473: Remove uneeded check before release_firmware()
author
Markus Elfring
<
[email protected]
>
Mon, 1 Dec 2014 21:55:29 +0000
(18:55 -0300)
committer
Mauro Carvalho Chehab
<
[email protected]
>
Thu, 4 Dec 2014 18:00:17 +0000
(16:00 -0200)
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <
[email protected]
>
Signed-off-by: Mauro Carvalho Chehab <
[email protected]
>
drivers/staging/media/mn88473/mn88473.c
patch
|
blob
|
history
diff --git
a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index 165933540b342483d1220599fd16157c7a3c5189..52180bbc36165c08ba8a588acc97906d5ac00fb7 100644
(file)
--- a/
drivers/staging/media/mn88473/mn88473.c
+++ b/
drivers/staging/media/mn88473/mn88473.c
@@
-262,8
+262,7
@@
static int mn88473_init(struct dvb_frontend *fe)
return 0;
err:
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;