mm: make early_pfn_to_nid() a C function
authorAndrew Morton <[email protected]>
Mon, 28 Apr 2008 09:12:39 +0000 (02:12 -0700)
committerLinus Torvalds <[email protected]>
Mon, 28 Apr 2008 15:58:20 +0000 (08:58 -0700)
Fix this (sparc64)

mm/sparse-vmemmap.c: In function `vmemmap_verify':
mm/sparse-vmemmap.c:64: warning: unused variable `pfn'

by switching to a C function which touches its arg.

(reason 3,555 why macros are bad)

Also, the `nid' arg was misnamed.

Reviewed-by: Christoph Lameter <[email protected]>
Acked-by: Andy Whitcroft <[email protected]>
Cc: Mel Gorman <[email protected]>
Cc: Andi Kleen <[email protected]>
Cc: KAMEZAWA Hiroyuki <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
include/linux/mmzone.h

index 498d6ceff2f41bfa88dac5538d96b8a0a83be594..0aece6d8937ecf51fba15e78e024d8d68eddb5f1 100644 (file)
@@ -841,7 +841,10 @@ static inline struct zoneref *first_zones_zonelist(struct zonelist *zonelist,
 
 #if !defined(CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID) && \
        !defined(CONFIG_ARCH_POPULATES_NODE_MAP)
-#define early_pfn_to_nid(nid)  (0UL)
+static inline unsigned long early_pfn_to_nid(unsigned long pfn)
+{
+       return 0;
+}
 #endif
 
 #ifdef CONFIG_FLATMEM