projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
44aa80f
)
edac: i5400: improve handling of pci_enable_device() return value
author
Kulikov Vasiliy
<
[email protected]
>
Wed, 11 Aug 2010 01:03:20 +0000
(18:03 -0700)
committer
Linus Torvalds
<
[email protected]
>
Wed, 11 Aug 2010 15:59:21 +0000
(08:59 -0700)
-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future. We should compare return
code with zero, not with concrete error value.
Signed-off-by: Kulikov Vasiliy <
[email protected]
>
Acked-by: Mauro Carvalho Chehab <
[email protected]
>
Cc: Jeff Roberson <
[email protected]
>
Cc: Doug Thompson <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: Linus Torvalds <
[email protected]
>
drivers/edac/i5400_edac.c
patch
|
blob
|
history
diff --git
a/drivers/edac/i5400_edac.c
b/drivers/edac/i5400_edac.c
index 010c1d6526f56fe6a33b2685e28ab6592dad8f80..38a9be9e1c7c5d40e19089250db4bed6a65901b7 100644
(file)
--- a/
drivers/edac/i5400_edac.c
+++ b/
drivers/edac/i5400_edac.c
@@
-1348,7
+1348,7
@@
static int __devinit i5400_init_one(struct pci_dev *pdev,
/* wake up device */
rc = pci_enable_device(pdev);
- if (rc
== -EIO
)
+ if (rc)
return rc;
/* now probe and enable the device */