ASoC: smdk_wm9713: fix resource leak in smdk_init error path

Fix the error path to properly free allocated resources.

Signed-off-by: Axel Lin <[email protected]>
Acked-by: Jassi Brar <[email protected]>
Acked-by: Liam Girdwood <[email protected]>
Signed-off-by: Mark Brown <[email protected]>

diff --git a/sound/soc/samsung/smdk_wm9713.c b/sound/soc/samsung/smdk_wm9713.c
index 7ce243086e7d2edb276000e16ecf11f4075d9e20..238cb3a38c5d423572746c3f12b9dcb32dad432d 100644 (file)
--- a/sound/soc/samsung/smdk_wm9713.c
+++ b/sound/soc/samsung/smdk_wm9713.c
@@ -70,24 +70,27 @@ static int __init smdk_init(void)
 
        ret = platform_device_add(smdk_snd_wm9713_device);
        if (ret)
-               goto err;
+               goto err1;
 
        smdk_snd_ac97_device = platform_device_alloc("soc-audio", -1);
        if (!smdk_snd_ac97_device) {
                ret = -ENOMEM;
-               goto err;
+               goto err2;
        }
 
        platform_set_drvdata(smdk_snd_ac97_device, &smdk);
 
        ret = platform_device_add(smdk_snd_ac97_device);
-       if (ret) {
-               platform_device_put(smdk_snd_ac97_device);
-               goto err;
-       }
+       if (ret)
+               goto err3;
 
        return 0;
-err:
+
+err3:
+       platform_device_put(smdk_snd_ac97_device);
+err2:
+       platform_device_del(smdk_snd_wm9713_device);
+err1:
        platform_device_put(smdk_snd_wm9713_device);
        return ret;
 }