tty: drop the pty lock during hangup

In theory we don't need it, in practice we are hitting some ill understood
deadlock when we don't drop it. The old code dropped it here so we are not
undoing anything problematic for pty. If pty could be unloaded it would be
a problem but it can't.

Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
index d6fa8429f3ff247527edeccb31d9653b29f0ba54..59af3945ea859c334719fed6a41b4192a30f87f5 100644 (file)
--- a/drivers/tty/pty.c
+++ b/drivers/tty/pty.c
@@ -63,7 +63,9 @@ static void pty_close(struct tty_struct *tty, struct file *filp)
                        mutex_unlock(&devpts_mutex);
                }
 #endif
+               tty_unlock(tty);
                tty_vhangup(tty->link);
+               tty_lock(tty);
        }
 }