perf build-id: Fix filename size calculation
authorNamhyung Kim <[email protected]>
Tue, 1 May 2012 14:19:36 +0000 (23:19 +0900)
committerArnaldo Carvalho de Melo <[email protected]>
Tue, 1 May 2012 17:13:00 +0000 (14:13 -0300)
The filename is a pointer variable so the sizeof(filename) will return
length of a pointer. Fix it by using 'size'.

Signed-off-by: Namhyung Kim <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
tools/perf/util/header.c

index 4c7c2d73251f81af31f6394c394baa0d17b64043..c0b70c697a363905d953b0af83202492c431ee80 100644 (file)
@@ -296,7 +296,7 @@ int build_id_cache__add_s(const char *sbuild_id, const char *debugdir,
        if (mkdir_p(filename, 0755))
                goto out_free;
 
-       snprintf(filename + len, sizeof(filename) - len, "/%s", sbuild_id);
+       snprintf(filename + len, size - len, "/%s", sbuild_id);
 
        if (access(filename, F_OK)) {
                if (is_kallsyms) {