drivers/video/backlight/lm3639_bl.c: remove ret = -EIO at error paths of probe
authorDevendra Naga <[email protected]>
Fri, 22 Feb 2013 00:43:52 +0000 (16:43 -0800)
committerLinus Torvalds <[email protected]>
Fri, 22 Feb 2013 01:22:24 +0000 (17:22 -0800)
The APIs are returning correctly the err codes, no need to assign -EIO
to the ret again.

Signed-off-by: Devendra Naga <[email protected]>
Acked-by: Daniel Jeong <[email protected]>
Cc: G.Shark Jeong <[email protected]>
Acked-by: Jingoo Han <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
drivers/video/backlight/lm3639_bl.c

index 7ab2d2a04e41a8aca4dc6e9e14a104fbebbe3cd3..053964da8dd3015e2a96ff2d7d9b5083dc6c4653 100644 (file)
@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
                                      &lm3639_bled_ops, &props);
        if (IS_ERR(pchip->bled)) {
                dev_err(&client->dev, "fail : backlight register\n");
-               ret = -EIO;
+               ret = PTR_ERR(pchip->bled);
                goto err_out;
        }
 
        ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
        if (ret < 0) {
                dev_err(&client->dev, "failed : add sysfs entries\n");
-               ret = -EIO;
                goto err_bled_mode;
        }
 
@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
                                    &client->dev, &pchip->cdev_flash);
        if (ret < 0) {
                dev_err(&client->dev, "fail : flash register\n");
-               ret = -EIO;
                goto err_flash;
        }
 
@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
                                    &client->dev, &pchip->cdev_torch);
        if (ret < 0) {
                dev_err(&client->dev, "fail : torch register\n");
-               ret = -EIO;
                goto err_torch;
        }