scripts/checkpatch.pl: device_initcall is not the only __initcall substitute
authorFabian Frederick <[email protected]>
Wed, 4 Jun 2014 23:12:10 +0000 (16:12 -0700)
committerLinus Torvalds <[email protected]>
Wed, 4 Jun 2014 23:54:20 +0000 (16:54 -0700)
This patch adds a link to init.h to find appropriate initcall function to
replace obsolete __initcall

Signed-off-by: Fabian Frederick <[email protected]>
Cc: Andy Whitcroft <[email protected]>
Cc: Joe Perches <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
scripts/checkpatch.pl

index 0ef4ae1de8ee2fa8a68b9b8f2e848f62b8cbcc26..010b18ef4ea0cb9e1575b9e54f3922c7bd7f9888 100755 (executable)
@@ -4551,10 +4551,10 @@ sub process {
                             "$1 is obsolete, use k$3 instead\n" . $herecurr);
                }
 
-# check for __initcall(), use device_initcall() explicitly please
+# check for __initcall(), use device_initcall() explicitly or more appropriate function please
                if ($line =~ /^.\s*__initcall\s*\(/) {
                        WARN("USE_DEVICE_INITCALL",
-                            "please use device_initcall() instead of __initcall()\n" . $herecurr);
+                            "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
                }
 
 # check for various ops structs, ensure they are const.