ASoC: sirf: Fix potential NULL pointer dereference

There is a potential execution path in which function
platform_get_resource() returns NULL. If this happens,
we will end up having a NULL pointer dereference.

Fix this by replacing devm_ioremap with devm_ioremap_resource,
which has the NULL check and the memory region request.

This code was detected with the help of Coccinelle.

Cc: [email protected]
Fixes: 2bd8d1d5cf89 ("ASoC: sirf: Add audio usp interface driver")
Signed-off-by: Gustavo A. R. Silva <[email protected]>
Signed-off-by: Mark Brown <[email protected]>

diff --git a/sound/soc/sirf/sirf-usp.c b/sound/soc/sirf/sirf-usp.c
index 77e7dcf969d0ce2e642f881c497d534bb7029df5..d70fcd4a1adf7428884bdf04400a5ecbb998845a 100644 (file)
--- a/sound/soc/sirf/sirf-usp.c
+++ b/sound/soc/sirf/sirf-usp.c
@@ -370,10 +370,9 @@ static int sirf_usp_pcm_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, usp);
 
        mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       base = devm_ioremap(&pdev->dev, mem_res->start,
-               resource_size(mem_res));
-       if (base == NULL)
-               return -ENOMEM;
+       base = devm_ioremap_resource(&pdev->dev, mem_res);
+       if (IS_ERR(base))
+               return PTR_ERR(base);
        usp->regmap = devm_regmap_init_mmio(&pdev->dev, base,
                                            &sirf_usp_regmap_config);
        if (IS_ERR(usp->regmap))