isdn: hisax: Fix test in waitforxfw
authorRoel Kluin <[email protected]>
Wed, 4 Nov 2009 16:31:19 +0000 (08:31 -0800)
committerDavid S. Miller <[email protected]>
Wed, 4 Nov 2009 16:31:19 +0000 (08:31 -0800)
The negation makes it a bool before the comparison and hence it
will never be 0x40.

Signed-off-by: Roel Kluin <[email protected]>
Cc: Karsten Keil <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
drivers/isdn/hisax/diva.c
drivers/isdn/hisax/hscx_irq.c

index 018bd293e580829a499bb4929f7513a23801907e..0b0c2e5d806b3b56b419549106332d49e2707ca9 100644 (file)
@@ -382,7 +382,7 @@ MemwaitforXFW(struct IsdnCardState *cs, int hscx)
 {
        int to = 50;
 
-       while ((!(MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) == 0x40) && to) {
+       while (((MemReadHSCX(cs, hscx, HSCX_STAR) & 0x44) != 0x40) && to) {
                udelay(1);
                to--;
        }
index 7b1ad5e4ecdac10a046d573761aeae11f00bdd65..2387d76c721a5fb5cd50b437c887b867e7fdd5d8 100644 (file)
@@ -32,7 +32,7 @@ waitforXFW(struct IsdnCardState *cs, int hscx)
 {
        int to = 50;
 
-       while ((!(READHSCX(cs, hscx, HSCX_STAR) & 0x44) == 0x40) && to) {
+       while (((READHSCX(cs, hscx, HSCX_STAR) & 0x44) != 0x40) && to) {
                udelay(1);
                to--;
        }