taskstats: add_del_listener() should ignore !valid listeners

When send_cpu_listeners() finds the orphaned listener it marks it as
!valid and drops listeners->sem.  Before it takes this sem for writing,
s->pid can be reused and add_del_listener() can wrongly try to re-use
this entry.

Change add_del_listener() to check ->valid = T.

Signed-off-by: Oleg Nesterov <[email protected]>
Reviewed-by: Vasiliy Kulikov <[email protected]>
Acked-by: Balbir Singh <[email protected]>
Cc: Jerome Marchand <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/kernel/taskstats.c b/kernel/taskstats.c
index a09a54936f1927d3f72cea4569f2a675748b8c0d..e19ce1454ee1d6d2e347e8c287abf2fe68fcc9e1 100644 (file)
--- a/kernel/taskstats.c
+++ b/kernel/taskstats.c
@@ -304,7 +304,7 @@ static int add_del_listener(pid_t pid, const struct cpumask *mask, int isadd)
                        listeners = &per_cpu(listener_array, cpu);
                        down_write(&listeners->sem);
                        list_for_each_entry(s2, &listeners->list, list) {
-                               if (s2->pid == pid)
+                               if (s2->pid == pid && s2->valid)
                                        goto exists;
                        }
                        list_add(&s->list, &listeners->list);