x86: Convert BUG() to use unreachable()

Use the new unreachable() macro instead of for(;;);.  When
allyesconfig is built with a GCC-4.5 snapshot on i686 the size of the
text segment is reduced by 3987 bytes (from 6827019 to 6823032).

Signed-off-by: David Daney <[email protected]>
Acked-by: "H. Peter Anvin" <[email protected]>
CC: Thomas Gleixner <[email protected]>
CC: Ingo Molnar <[email protected]>
CC: [email protected]
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h
index d9cf1cd156d24b5cebe5a8ed41292b6300e8c9c2..f654d1bb17fb6cf3f0199dd820bd2da2f8b52901 100644 (file)
--- a/arch/x86/include/asm/bug.h
+++ b/arch/x86/include/asm/bug.h
@@ -22,14 +22,14 @@ do {                                                                \
                     ".popsection"                              \
                     : : "i" (__FILE__), "i" (__LINE__),        \
                     "i" (sizeof(struct bug_entry)));           \
-       for (;;) ;                                              \
+       unreachable();                                          \
 } while (0)
 
 #else
 #define BUG()                                                  \
 do {                                                           \
        asm volatile("ud2");                                    \
-       for (;;) ;                                              \
+       unreachable();                                          \
 } while (0)
 #endif