ath79: ag71xx: fix error handling for of_get_phy_mode

Errors are not indicated by the phy_mode value but returned separately
from the function.

Signed-off-by: David Bauer <[email protected]>

diff --git a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
index d0605685934b7320211016b4f357beb9f2192bba..463083628fbeeefe05d45bd0cf2c29ff21021212 100644 (file)
--- a/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
+++ b/target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c
@@ -1677,12 +1677,12 @@ static int ag71xx_probe(struct platform_device *pdev)
        }
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,10,0)
-       of_get_phy_mode(np, &ag->phy_if_mode);
+       err = of_get_phy_mode(np, &ag->phy_if_mode);
+       if (err < 0) {
 #else
        ag->phy_if_mode = of_get_phy_mode(np);
-#endif
-
        if (ag->phy_if_mode < 0) {
+#endif
                dev_err(&pdev->dev, "missing phy-mode property in DT\n");
                return ag->phy_if_mode;
        }