drm/amd/powerplay: fix memory leakage when reload (v2)

add smu_free_memory when smu fini to prevent memory leakage

v2: squash in typo fix (Yintian) and warning (Harry)

Signed-off-by: Yintian Tao <[email protected]>
Reviewed-by: Alex Deucher <[email protected]>
Signed-off-by: Alex Deucher <[email protected]>

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
index cb95e882b98f9f2ccdcd9ef92776709d614d3d99..311ff371861899c5434eced750aabf8330c814a2 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c
@@ -648,6 +648,12 @@ int smu7_init(struct pp_hwmgr *hwmgr)
 
 int smu7_smu_fini(struct pp_hwmgr *hwmgr)
 {
+       struct smu7_smumgr *smu_data = (struct smu7_smumgr *)(hwmgr->smu_backend);
+
+       smu_free_memory(hwmgr->device, (void *) smu_data->header_buffer.handle);
+       if (!cgs_is_virtualization_enabled(hwmgr->device))
+               smu_free_memory(hwmgr->device, (void *) smu_data->smu_buffer.handle);
+
        kfree(hwmgr->smu_backend);
        hwmgr->smu_backend = NULL;
        cgs_rel_firmware(hwmgr->device, CGS_UCODE_ID_SMU);