net/mlx5e: Avoid redundant dev_kfree_skb() upon NOP completion

NOP completion SKBs are always NULL.

Signed-off-by: Achiad Shochat <[email protected]>
Signed-off-by: Saeed Mahameed <[email protected]>
Signed-off-by: Or Gerlitz <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
index c0566b6847780fb08d526e28c4a50ab49a4ba777..f5c7d78c64f7d5b81a063401946e7690689c5e88 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c
@@ -294,7 +294,7 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq)
                if (unlikely(!skb)) { /* nop */
                        sq->stats.nop++;
                        sqcc++;
-                       goto free_skb;
+                       continue;
                }
 
                for (j = 0; j < MLX5E_TX_SKB_CB(skb)->num_dma; j++) {
@@ -309,8 +309,6 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq)
                npkts++;
                nbytes += MLX5E_TX_SKB_CB(skb)->num_bytes;
                sqcc += MLX5E_TX_SKB_CB(skb)->num_wqebbs;
-
-free_skb:
                dev_kfree_skb(skb);
        }