projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8ac62dc
)
[IPV6]: dst_entry leak in ip4ip6_err. (resend)
author
Denis V. Lunev
<
[email protected]
>
Tue, 19 Feb 2008 04:49:36 +0000
(20:49 -0800)
committer
David S. Miller
<
[email protected]
>
Tue, 19 Feb 2008 04:49:36 +0000
(20:49 -0800)
The result of the ip_route_output is not assigned to skb. This means that
- it is leaked
- possible OOPS below dereferrencing skb->dst
- no ICMP message for this case
Signed-off-by: Denis V. Lunev <
[email protected]
>
Signed-off-by: David S. Miller <
[email protected]
>
net/ipv6/ip6_tunnel.c
patch
|
blob
|
history
diff --git
a/net/ipv6/ip6_tunnel.c
b/net/ipv6/ip6_tunnel.c
index 9031e521c1df72ce10e1c94397de301e3e203317..cd940647bd12581a53951dcab80f014ec7803009 100644
(file)
--- a/
net/ipv6/ip6_tunnel.c
+++ b/
net/ipv6/ip6_tunnel.c
@@
-550,6
+550,7
@@
ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
ip_rt_put(rt);
goto out;
}
+ skb2->dst = (struct dst_entry *)rt;
} else {
ip_rt_put(rt);
if (ip_route_input(skb2, eiph->daddr, eiph->saddr, eiph->tos,