projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
968e517
)
tracing: Have error path in predicate_parse() free its allocated memory
author
Navid Emamdoost
<
[email protected]
>
Fri, 20 Sep 2019 22:57:59 +0000
(17:57 -0500)
committer
Steven Rostedt (VMware)
<
[email protected]
>
Sat, 28 Sep 2019 21:13:39 +0000
(17:13 -0400)
In predicate_parse, there is an error path that is not going to
out_free instead it returns directly which leads to a memory leak.
Link:
http://lkml.kernel.org/r/
[email protected]
Signed-off-by: Navid Emamdoost <
[email protected]
>
Signed-off-by: Steven Rostedt (VMware) <
[email protected]
>
kernel/trace/trace_events_filter.c
patch
|
blob
|
history
diff --git
a/kernel/trace/trace_events_filter.c
b/kernel/trace/trace_events_filter.c
index c773b8fb270c51a99f259edb51fd1f55b7202517..c9a74f82b14a279c270268c43cad6287d691d438 100644
(file)
--- a/
kernel/trace/trace_events_filter.c
+++ b/
kernel/trace/trace_events_filter.c
@@
-452,8
+452,10
@@
predicate_parse(const char *str, int nr_parens, int nr_preds,
switch (*next) {
case '(': /* #2 */
- if (top - op_stack > nr_parens)
- return ERR_PTR(-EINVAL);
+ if (top - op_stack > nr_parens) {
+ ret = -EINVAL;
+ goto out_free;
+ }
*(++top) = invert;
continue;
case '!': /* #3 */