net/mlxfw: remove redundant goto on error check

The check to see of err is set and the subsequent goto is extraneous
as the next statement is where the goto is jumping to. Remove this
redundant check and goto.

Detected by CoverityScan, CID#1437734 ("Identical code for
different branches")

Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Yotam Gigi <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
index 7e9589061d30ebcf95125bb5dc6e1088f999d1fe..628150d28061781aded9ed9cfd1757ef5809bfe3 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
+++ b/drivers/net/ethernet/mellanox/mlxfw/mlxfw_mfa2.c
@@ -492,8 +492,6 @@ static int mlxfw_mfa2_file_cb_offset_xz(const struct mlxfw_mfa2_file *mfa2_file,
        dec_buf.out_pos = 0;
        dec_buf.out_size = size;
        err = mlxfw_mfa2_xz_dec_run(xz_dec, &dec_buf, &finished);
-       if (err)
-               goto out;
 out:
        xz_dec_end(xz_dec);
        return err;