lib: introduce common method to convert hex digits

hex_to_bin() is a little method which converts hex digit to its actual
value.  There are plenty of places where such functionality is needed.

[[email protected]: use tolower(), saving 3 bytes, test the more common case first - it's quicker]
[[email protected]: relocate tolower to make it even faster! (Joe)]
Signed-off-by: Andy Shevchenko <[email protected]>
Cc: Tilman Schmidt <[email protected]>
Cc: Duncan Sands <[email protected]>
Cc: Eric W. Biederman <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: "Richard Russon (FlatCap)" <[email protected]>
Cc: John W. Linville <[email protected]>
Cc: Len Brown <[email protected]>
Cc: Joe Perches <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 05f332afc9e01f583056112bbea824555358358b..8317ec4b9f3b4bbe615109073e7bd8ad9b946c1b 100644 (file)
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -375,6 +375,8 @@ static inline char *pack_hex_byte(char *buf, u8 byte)
        return buf;
 }
 
+extern int hex_to_bin(char ch);
+
 #ifndef pr_fmt
 #define pr_fmt(fmt) fmt
 #endif

diff --git a/lib/hexdump.c b/lib/hexdump.c
index 1bd6a9779774455050d2df928104973565672f90..5d7a4802c5623c00056159735bf73d17165ba476 100644 (file)
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -15,6 +15,24 @@
 const char hex_asc[] = "0123456789abcdef";
 EXPORT_SYMBOL(hex_asc);
 
+/**
+ * hex_to_bin - convert a hex digit to its real value
+ * @ch: ascii character represents hex digit
+ *
+ * hex_to_bin() converts one hex digit to its actual value or -1 in case of bad
+ * input.
+ */
+int hex_to_bin(char ch)
+{
+       if ((ch >= '0') && (ch <= '9'))
+               return ch - '0';
+       ch = tolower(ch);
+       if ((ch >= 'a') && (ch <= 'f'))
+               return ch - 'a' + 10;
+       return -1;
+}
+EXPORT_SYMBOL(hex_to_bin);
+
 /**
  * hex_dump_to_buffer - convert a blob of data to "hex ASCII" in memory
  * @buf: data blob to dump