projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1b22b4b
)
MIPS: OCTEON: irq: Check for null return on kzalloc allocation
author
Colin Ian King
<
[email protected]
>
Thu, 22 Feb 2018 18:08:53 +0000
(18:08 +0000)
committer
James Hogan
<
[email protected]
>
Fri, 23 Feb 2018 09:44:46 +0000
(09:44 +0000)
The allocation of host_data is not null checked, leading to a null
pointer dereference if the allocation fails. Fix this by adding a null
check and return with -ENOMEM.
Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes")
Signed-off-by: Colin Ian King <
[email protected]
>
Acked-by: David Daney <
[email protected]
>
Cc: Ralf Baechle <
[email protected]
>
Cc: "Steven J. Hill" <
[email protected]
>
Cc:
[email protected]
Cc: <
[email protected]
> # 4.0+
Patchwork: https://patchwork.linux-mips.org/patch/18658/
Signed-off-by: James Hogan <
[email protected]
>
arch/mips/cavium-octeon/octeon-irq.c
patch
|
blob
|
history
diff --git
a/arch/mips/cavium-octeon/octeon-irq.c
b/arch/mips/cavium-octeon/octeon-irq.c
index 5b3a3f6a9ad31fd845bd18cdd3197d9c75833c84..d99f5242169e7acb31f8cfa71cd6e14d24e94c82 100644
(file)
--- a/
arch/mips/cavium-octeon/octeon-irq.c
+++ b/
arch/mips/cavium-octeon/octeon-irq.c
@@
-2277,6
+2277,8
@@
static int __init octeon_irq_init_cib(struct device_node *ciu_node,
}
host_data = kzalloc(sizeof(*host_data), GFP_KERNEL);
+ if (!host_data)
+ return -ENOMEM;
raw_spin_lock_init(&host_data->lock);
addr = of_get_address(ciu_node, 0, NULL, NULL);