powerpc: fix compile fail in hugetlb cmdline parsing
authorPaul Gortmaker <[email protected]>
Mon, 7 May 2012 14:32:22 +0000 (10:32 -0400)
committerGreg Kroah-Hartman <[email protected]>
Mon, 7 May 2012 23:51:19 +0000 (16:51 -0700)
Commit 9fb48c744ba6a4bf58b666f4e6fdac3008ea1bd4

    "params: add 3rd arg to option handler callback signature"

added an extra arg to the function, but didn't catch all the use
cases needing it, causing this compile fail in mpc85xx_defconfig:

 arch/powerpc/mm/hugetlbpage.c:316:4: error: passing argument 7 of
 'parse_args' from incompatible pointer type [-Werror]

 include/linux/moduleparam.h:317:12: note: expected
 'int (*)(char *, char *, const char *)' but argument is of type
 'int (*)(char *, char *)'

This function has no need to printk out the "doing" value, so
just add the arg as an "unused".

Cc: Rusty Russell <[email protected]>
Cc: Jim Cromie <[email protected]>
Cc: Jason Baron <[email protected]>
Cc: Becky Bruce <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Signed-off-by: Paul Gortmaker <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
arch/powerpc/mm/hugetlbpage.c

index fb05b123218f389eaea96a9022d5b39f8cd18188..1a6de0a7d8eba53a516bc0f6359cbd5240580b15 100644 (file)
@@ -271,7 +271,8 @@ int alloc_bootmem_huge_page(struct hstate *hstate)
 
 unsigned long gpage_npages[MMU_PAGE_COUNT];
 
-static int __init do_gpage_early_setup(char *param, char *val)
+static int __init do_gpage_early_setup(char *param, char *val,
+                                      const char *unused)
 {
        static phys_addr_t size;
        unsigned long npages;