x86, efi: correct precedence of operators in setup_efi_pci
authorSasha Levin <[email protected]>
Thu, 20 Dec 2012 19:11:33 +0000 (14:11 -0500)
committerH. Peter Anvin <[email protected]>
Thu, 20 Dec 2012 19:47:14 +0000 (11:47 -0800)
With the current code, the condition in the if() doesn't make much sense due to
precedence of operators.

Signed-off-by: Sasha Levin <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Cc: Matt Fleming <[email protected]>
Cc: Matthew Garrett <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: Seth Forshee <[email protected]>
Signed-off-by: H. Peter Anvin <[email protected]>
arch/x86/boot/compressed/eboot.c

index b1942e222768e7c9c2707c14dbdbd9643a51a8b9..18e329ca108e5f720adf1974fa1e90c8b2626991 100644 (file)
@@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params)
                if (status != EFI_SUCCESS)
                        continue;
 
-               if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)
+               if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM))
                        continue;
 
                if (!pci->romimage || !pci->romsize)