realtek: ethernet: Avoid usage of unsafe strcpy

strcpy doesn't check the length of the destination buffer. And strlcpy
would not make sure to null-terminate the destination buffer.

Even when it is clear that this string will fit in the currrent buffer, it
is just best practice to avoid strcpy.

Signed-off-by: Sven Eckelmann <[email protected]>
Link: https://github.com/openwrt/openwrt/pull/20906
Signed-off-by: Hauke Mehrtens <[email protected]>

diff --git a/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c
index d9c0fb16a38066d8f94f0dad6ef71efdcc37e73b..91ea29d6c002dca1d07bb7b64dd4e1b4b843dd3a 100644 (file)
--- a/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c
+++ b/target/linux/realtek/files-6.12/drivers/net/ethernet/rtl838x_eth.c
@@ -1798,7 +1798,8 @@ static int __init rtl838x_eth_probe(struct platform_device *pdev)
        }
        pr_info("Using MAC %08x%08x\n", sw_r32(priv->r->mac),
                                        sw_r32(priv->r->mac + 4));
-       strcpy(dev->name, "eth%d");
+       strscpy(dev->name, "eth%d", sizeof(dev->name));
+
        priv->pdev = pdev;
        priv->netdev = dev;