projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
92e963f
)
rtc: max77686: Fix max77686_rtc_read_alarm() return value
author
Javier Martinez Canillas
<
[email protected]
>
Wed, 27 Jan 2016 03:36:37 +0000
(
00:36
-0300)
committer
Alexandre Belloni
<
[email protected]
>
Thu, 4 Feb 2016 22:42:06 +0000
(23:42 +0100)
The function is always returning zero even in case of failures since
the ret value was not propagated to the callers. Fix the error path.
Reported-by: Krzysztof Kozlowski <
[email protected]
>
Signed-off-by: Javier Martinez Canillas <
[email protected]
>
Reviewed-by: Krzysztof Kozlowski <
[email protected]
>
Tested-by: Krzysztof Kozlowski <
[email protected]
>
Acked-by: Laxman Dewangan <
[email protected]
>
Reviewed-by: Andi Shyti <
[email protected]
>
Signed-off-by: Alexandre Belloni <
[email protected]
>
drivers/rtc/rtc-max77686.c
patch
|
blob
|
history
diff --git
a/drivers/rtc/rtc-max77686.c
b/drivers/rtc/rtc-max77686.c
index 7184a0eda79384f8a59a5c8be8155018ba1a792e..6653c3d11b668abed47e32068448ee9150b528b0 100644
(file)
--- a/
drivers/rtc/rtc-max77686.c
+++ b/
drivers/rtc/rtc-max77686.c
@@
-235,7
+235,7
@@
static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
out:
mutex_unlock(&info->lock);
- return
0
;
+ return
ret
;
}
static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info)