RDS: validate the requested traces user input against max supported

Larger than supported value can lead to array read/write overflow.

Reported-by: Colin Ian King <[email protected]>
Signed-off-by: Santosh Shilimkar <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c
index fd8217404162ecd8136554e3de567d98bbbf80b2..b405f77d664ca0a10472f78c66294c21fcc03680 100644 (file)
--- a/net/rds/af_rds.c
+++ b/net/rds/af_rds.c
@@ -310,6 +310,9 @@ static int rds_recv_track_latency(struct rds_sock *rs, char __user *optval,
        if (copy_from_user(&trace, optval, sizeof(trace)))
                return -EFAULT;
 
+       if (trace.rx_traces > RDS_MSG_RX_DGRAM_TRACE_MAX)
+               return -EFAULT;
+
        rs->rs_rx_traces = trace.rx_traces;
        for (i = 0; i < rs->rs_rx_traces; i++) {
                if (trace.rx_trace_pos[i] > RDS_MSG_RX_DGRAM_TRACE_MAX) {