xen/pvcalls: remove redundant check for irq >= 0

This is a moot point, but irq is always less than zero at the label
out_error, so the check for irq >= 0 is redundant and can be removed.

Detected by CoverityScan, CID#1460371 ("Logically dead code")

Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command")
Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Juergen Gross <[email protected]>
Signed-off-by: Boris Ostrovsky <[email protected]>

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 60a0ad81d4cf2ecc704091c119bb11eae98330b7..2925b2f095ede2eed884c132237b859eb32bd2bf 100644 (file)
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
        return 0;
 
 out_error:
-       if (irq >= 0)
-               unbind_from_irqhandler(irq, map);
-       else if (*evtchn >= 0)
+       if (*evtchn >= 0)
                xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
        kfree(map->active.data.in);
        kfree(map->active.ring);