qlcnic: Fix a memory leak in error handling path

If 'dma_alloc_coherent()' fails, we should release resources allocated so
far, just as done in all other cases in this function.

Signed-off-by: Christophe JAILLET <[email protected]>
Signed-off-by: David S. Miller <[email protected]>

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index daf05155b7329abdda58e63b1c19be9e06adc699..d344e9d438321873fa8e4dedf745a74aeeb3db52 100644 (file)
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -573,8 +573,10 @@ int qlcnic_alloc_hw_resources(struct qlcnic_adapter *adapter)
                ptr = (__le32 *)dma_alloc_coherent(&pdev->dev, sizeof(u32),
                                                   &tx_ring->hw_cons_phys_addr,
                                                   GFP_KERNEL);
-               if (ptr == NULL)
-                       return -ENOMEM;
+               if (ptr == NULL) {
+                       err = -ENOMEM;
+                       goto err_out_free;
+               }
 
                tx_ring->hw_consumer = ptr;
                /* cmd desc ring */