ALSA: asihpi - Fix potential Oops in snd_asihpi_cmode_info()

Dan Carpenter reported that setting 0 to uinfo->value.enumerated.items
in snd_asihpi_cmode_info() may lead to Oops.  This function should
return an error immediately in such a case instead.

Cc: Dan Carpenter <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>

diff --git a/sound/pci/asihpi/asihpi.c b/sound/pci/asihpi/asihpi.c
index fd3926fb0a082321a828581fec36b41ad89aba40..e8de831f98bc510c6cde42159bce817dad45408b 100644 (file)
--- a/sound/pci/asihpi/asihpi.c
+++ b/sound/pci/asihpi/asihpi.c
@@ -2259,6 +2259,9 @@ static int snd_asihpi_cmode_info(struct snd_kcontrol *kcontrol,
                        valid_modes++;
                        }
 
+       if (!valid_modes)
+               return -EINVAL;
+
        uinfo->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
        uinfo->count = 1;
        uinfo->value.enumerated.items = valid_modes;