bpf: devmap: remove redundant assignment of dev = dev

The assignment dev = dev is redundant and should be removed.

Detected by CoverityScan, CID#1469486 ("Evaluation order violation")

Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Song Liu <[email protected]>
Signed-off-by: Alexei Starovoitov <[email protected]>

diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index ae16d0c373efb0271deaa1ec8b231582d48dd9fa..1fe3fe60508aa9a7cab3ed37ae09aa23fab118a0 100644 (file)
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
 static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
 {
        struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
-       struct net_device *dev = dev = obj ? obj->dev : NULL;
+       struct net_device *dev = obj ? obj->dev : NULL;
 
        return dev ? &dev->ifindex : NULL;
 }