nl80211: Fix potential memory leak in nl80211_connect

Free cached keys if the last early return path is taken.

Signed-off-by: Ola Olsson <[email protected]>
Signed-off-by: Johannes Berg <[email protected]>

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 624174f20b1f8b7e264f1e5e715660fd785c4646..75b0d23ee882293a07fb9e236757931780def482 100644 (file)
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -7941,8 +7941,10 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info)
        if (nla_get_flag(info->attrs[NL80211_ATTR_USE_RRM])) {
                if (!(rdev->wiphy.features &
                      NL80211_FEATURE_DS_PARAM_SET_IE_IN_PROBES) ||
-                   !(rdev->wiphy.features & NL80211_FEATURE_QUIET))
+                   !(rdev->wiphy.features & NL80211_FEATURE_QUIET)) {
+                       kzfree(connkeys);
                        return -EINVAL;
+               }
                connect.flags |= ASSOC_REQ_USE_RRM;
        }