projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
788b0bc
)
usb: gadget: Fix return value check in ep_write()
author
Wei Yongjun
<
[email protected]
>
Sun, 20 Jul 2014 03:42:07 +0000
(11:42 +0800)
committer
Felipe Balbi
<
[email protected]
>
Tue, 19 Aug 2014 14:27:24 +0000
(09:27 -0500)
In case of error, the function memdup_user() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <
[email protected]
>
Signed-off-by: Felipe Balbi <
[email protected]
>
drivers/usb/gadget/legacy/inode.c
patch
|
blob
|
history
diff --git
a/drivers/usb/gadget/legacy/inode.c
b/drivers/usb/gadget/legacy/inode.c
index 2e4ce7704908bc78e4ed2385842a1e6dbec1d59c..e96077b8bf7922b89b5feda9a9c34b3de843ab55 100644
(file)
--- a/
drivers/usb/gadget/legacy/inode.c
+++ b/
drivers/usb/gadget/legacy/inode.c
@@
-440,7
+440,7
@@
ep_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr)
value = -ENOMEM;
kbuf = memdup_user(buf, len);
- if (
!kbuf
) {
+ if (
IS_ERR(kbuf)
) {
value = PTR_ERR(kbuf);
goto free1;
}