Input: xpad - fix a memory leak

In xpad_led_disconnect(), what we really want is to kfree(xpad_led).
In xpad_disconnect(), add a missing kfree(xpad->bdata) to fix the memory leak.

Signed-off-by: Axel Lin <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 39c0265ca156d7c5633cdee9b1375a01ff1ea0b5..e8b2ece3e01e496a5b88b5110e5388182cfe97d7 100644 (file)
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -732,7 +732,7 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
 
        if (xpad_led) {
                led_classdev_unregister(&xpad_led->led_cdev);
-               kfree(xpad_led->name);
+               kfree(xpad_led);
        }
 }
 #else
@@ -921,7 +921,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
        usb_set_intfdata(intf, xpad);
 
        /*
-        * Submit the int URB immediatly rather than waiting for open
+        * Submit the int URB immediately rather than waiting for open
         * because we get status messages from the device whether
         * or not any controllers are attached.  In fact, it's
         * exactly the message that a controller has arrived that
@@ -1000,6 +1000,7 @@ static void xpad_disconnect(struct usb_interface *intf)
                usb_free_urb(xpad->irq_in);
                usb_free_coherent(xpad->udev, XPAD_PKT_LEN,
                                xpad->idata, xpad->idata_dma);
+               kfree(xpad->bdata);
                kfree(xpad);
        }
 }