ALSA: asihp: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>

diff --git a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c
index bd47521b24ec1fa336f0b0a952d2b41c39cc5dd6..44c7eb4a3f1d6f5828d845b6c0d156d6bf24df70 100644 (file)
--- a/sound/pci/asihpi/hpicmn.c
+++ b/sound/pci/asihpi/hpicmn.c
@@ -631,7 +631,7 @@ struct hpi_control_cache *hpi_alloc_control_cache(const u32 control_count,
        if (!p_cache)
                return NULL;
 
-       p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count,
+       p_cache->p_info = kcalloc(control_count, sizeof(*p_cache->p_info),
                                  GFP_KERNEL);
        if (!p_cache->p_info) {
                kfree(p_cache);