projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8addc2d
)
proc: fix smaps and meminfo alignment
author
Hugh Dickins
<
[email protected]
>
Fri, 25 May 2018 21:47:50 +0000
(14:47 -0700)
committer
Linus Torvalds
<
[email protected]
>
Sat, 26 May 2018 01:12:11 +0000
(18:12 -0700)
The 4.17-rc /proc/meminfo and /proc/<pid>/smaps look ugly: single-digit
numbers (commonly 0) are misaligned.
Remove seq_put_decimal_ull_width()'s leftover optimization for single
digits: it's wrong now that num_to_str() takes care of the width.
Link:
http://lkml.kernel.org/r/
[email protected]
Fixes: d1be35cb6f96 ("proc: add seq_put_decimal_ull_width to speed up /proc/pid/smaps")
Signed-off-by: Hugh Dickins <
[email protected]
>
Cc: Andrei Vagin <
[email protected]
>
Cc: Alexey Dobriyan <
[email protected]
>
Signed-off-by: Andrew Morton <
[email protected]
>
Signed-off-by: Linus Torvalds <
[email protected]
>
fs/seq_file.c
patch
|
blob
|
history
diff --git
a/fs/seq_file.c
b/fs/seq_file.c
index c6c27f1f9c9850634700e4898adae6ab7755e113..4cc090b50cc528a2185a567656f835790e0f09bc 100644
(file)
--- a/
fs/seq_file.c
+++ b/
fs/seq_file.c
@@
-709,11
+709,6
@@
void seq_put_decimal_ull_width(struct seq_file *m, const char *delimiter,
if (m->count + width >= m->size)
goto overflow;
- if (num < 10) {
- m->buf[m->count++] = num + '0';
- return;
- }
-
len = num_to_str(m->buf + m->count, m->size - m->count, num, width);
if (!len)
goto overflow;