projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
1cc6adf
)
[media] siano: unnecessary check before rc_unregister_device()
author
Markus Elfring
<
[email protected]
>
Mon, 24 Nov 2014 21:32:30 +0000
(18:32 -0300)
committer
Mauro Carvalho Chehab
<
[email protected]
>
Tue, 25 Nov 2014 15:44:34 +0000
(13:44 -0200)
The rc_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <
[email protected]
>
Signed-off-by: Mauro Carvalho Chehab <
[email protected]
>
drivers/media/common/siano/smsir.c
patch
|
blob
|
history
diff --git
a/drivers/media/common/siano/smsir.c
b/drivers/media/common/siano/smsir.c
index 273043ea8f47e9b425d01be28c4fdaf68228de33..35d0e887bd6562ea53eda53482f9075ac282186e 100644
(file)
--- a/
drivers/media/common/siano/smsir.c
+++ b/
drivers/media/common/siano/smsir.c
@@
-107,8
+107,7
@@
int sms_ir_init(struct smscore_device_t *coredev)
void sms_ir_exit(struct smscore_device_t *coredev)
{
- if (coredev->ir.dev)
- rc_unregister_device(coredev->ir.dev);
+ rc_unregister_device(coredev->ir.dev);
sms_log("");
}