KVM: fix lock imbalance in kvm_create_pit()

Stanse found that there is an omitted unlock in kvm_create_pit in one fail
path. Add proper unlock there.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Avi Kivity <[email protected]>
Cc: Marcelo Tosatti <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: [email protected]
Cc: Gleb Natapov <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Gregory Haskins <[email protected]>
Cc: [email protected]
Signed-off-by: Avi Kivity <[email protected]>

diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 467cc47fb7334bfd485ea627f2315b1e7aa9eeb3..70db4d435393f3546365e58745762304d97e0ea4 100644 (file)
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
@@ -696,6 +696,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 
        pit->wq = create_singlethread_workqueue("kvm-pit-wq");
        if (!pit->wq) {
+               mutex_unlock(&pit->pit_state.lock);
                kfree(pit);
                return NULL;
        }