projects
/
openwrt
/
staging
/
blogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a2ca8ec
)
iwlegacy: don't return zero on failure paths in il4965_pci_probe()
author
Alexey Khoroshilov
<
[email protected]
>
Sat, 19 Jan 2013 12:56:34 +0000
(16:56 +0400)
committer
John W. Linville
<
[email protected]
>
Tue, 22 Jan 2013 21:01:30 +0000
(16:01 -0500)
If hardware is not ready, il4965_pci_probe() breaks off initialization,
deallocates all resources, but returns zero.
The patch adds -EIO as return value in this case.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <
[email protected]
>
Signed-off-by: John W. Linville <
[email protected]
>
drivers/net/wireless/iwlegacy/4965-mac.c
patch
|
blob
|
history
diff --git
a/drivers/net/wireless/iwlegacy/4965-mac.c
b/drivers/net/wireless/iwlegacy/4965-mac.c
index 10fc2493f415c99e8cea2156999b8a62faaaa728..f1dc040065646c5ec9d15068a084ff22d00eb656 100644
(file)
--- a/
drivers/net/wireless/iwlegacy/4965-mac.c
+++ b/
drivers/net/wireless/iwlegacy/4965-mac.c
@@
-6556,6
+6556,7
@@
il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
il4965_prepare_card_hw(il);
if (!il->hw_ready) {
IL_WARN("Failed, HW not ready\n");
+ err = -EIO;
goto out_iounmap;
}